Enable flake8 in github actions #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epenet
commented
Apr 1, 2022
Comment on lines
+6
to
+7
| ; W504 line break after binary operator | ||
| ignore = E501,W504 |
There was a problem hiding this comment.
We need to choose between ignoring W503 or W504
I would prefer to ignore W503 and enable W504, but current code is formatted with line break after so...
There was a problem hiding this comment.
I will merge this PR as-is with W504 being ignored, and push a second PR to change that, since I already locally switched to ignoring W503 while testing the flake8 setup.
epenet
force-pushed
the
flake8
branch
2 times, most recently
from
5804a58 to
4a1797b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #457