Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme, add BCH #120

Merged
merged 1 commit into from
Aug 9, 2017
Merged

Update Readme, add BCH #120

merged 1 commit into from
Aug 9, 2017

Conversation

elsesiy
Copy link
Contributor

@elsesiy elsesiy commented Aug 9, 2017

Pull Request Label:

  • Bug
  • New feature
  • Enhancement
  • New component
  • Typo

Pull Request Checklist:


Fixed the wrong instructions in Readme and added Bitcoin Cash prior to adding the other functionality we were talking about.

Cheers, Jonas

@alexanderepstein
Copy link
Owner

Looks good! Thanks for contributing 🎊 Do you still have plans to add the two way conversion and the other features you mentioned in the original PR?

@alexanderepstein alexanderepstein merged commit 7c8d5f9 into alexanderepstein:master Aug 9, 2017
@elsesiy
Copy link
Contributor Author

elsesiy commented Aug 9, 2017

Yes, I'll eventually find the time ;)

@elsesiy
Copy link
Contributor Author

elsesiy commented Sep 27, 2017

@alexanderepstein As you realized my idea yourself with cryptowatch I take it that I won't need to add this feature to cryptocurrency anymore, right?

@alexanderepstein
Copy link
Owner

@elsesiy If you want to add the features still feel free to and I will definitely merge the PR. If not cryptowatch does slightly suffice but it still cannot handle more than bitcoin, ethereum and litecoin at the moment although if extended it could support those as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants