Don't throw errors when using SSL #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Thanks for this! Looks good--will merge soon. I'm still debating about the best way to deal with the local MaxMind stuff. See #581 for discussion (opinions welcome!). |
alexreisner
added a commit
that referenced
this pull request
Jan 29, 2014
Don't throw errors when using SSL
|
@alexreisner is there an ETA on the next gem release? Currently using the github version, would like to switch a client back to the gem. Thanks 😄 |
|
@UnderpantsGnome Hoping to release some time in April. Need to address #630 first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting config
:use_ssl => truecurrently raisesIOErrorfromNet::HTTP; Becausestartis called before setting theuse_sslflag. This patch sets up all of the required args before callingstart, and uses.geton the existing client rather than instantiating a new instance of Net::HTTP::Get.As a sidebar, MaxmindLocal tests are erroring, presumably because they exist yet
maxmind_localisn't being required. Not sure what the gameplan is for that, so I left it alone. The rest of the tests are passing.