Remove DEFAULT_HOST #153
Merged
Remove DEFAULT_HOST #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few places we relied on "localhost" as a default if a URL's host was not set, but I think it's better to error out in these cases.
In general, there are a few places in Unit that assumed there is a host as part of the URL. I've made that explicit by doing a check at the beginning of
connect(). I've also tried to plumb through the semantics of "host is always present" by changing the parameter types of some of the functions that use the hostname.I considered a more thorough way to express this with types - for instance implementing an
HttpUrlstruct that embeds aUrl, and exports most of the same methods, but guarantees that host is always present. However, that was more invasive than this so I did a smaller change to start.