Don't export Header struct #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algesten
force-pushed
the
fix/no-header-struct
branch
from
a7f058a to
63c97d8
Compare
This struct does not need to be exported from the crate because it is not used in any public fn - it's internal. This is technically a breaking change, but in practice, not too bad since the struct is not used by the API.
algesten
force-pushed
the
fix/no-header-struct
branch
from
63c97d8 to
39ff926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This struct does not need to be exported from the crate because it
is not used in any public fn - it's internal.
This is technically a breaking change, but in practice, not too bad
since the struct is not used by the API.