proxy: use the same data for CONNECT and Host header #967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CONNECT and Host header should both point to the proxied host that we want to eventually reach, not to the proxy itself.
I'm no expert on proxies but MDN suggest that these headers should use the same data: https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/CONNECT
Also I used to be able to send proxied requests via
socat
to an Nginx with ureq < 3.0.0 and now it doesn't work anymore.socat
now forwards the HTTP request as is to Nginx (telling me it doesn't recognize it as a valid proxy request) and Nginx replies with a 400. In previous ureq versions the CONNECT and Host headers used the same data: https://github.com/algesten/ureq/blob/2.12.1/src/proxy.rs#L187