Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the url+anchor concatenation #53

Closed
pixelastic opened this issue Dec 24, 2015 · 1 comment
Closed

Remove the url+anchor concatenation #53

pixelastic opened this issue Dec 24, 2015 · 1 comment
Assignees
@bobylito

Comments

@pixelastic
Copy link
Contributor

There is something confusing with the way we store the url and anchor.

The scraper index both a anchor field and a url one, but the url already contains the anchor. We do that because we're doing a distinct on the url. But the JS client also concatenate the url and anchor, which results in weird things.

I think we should:

  • Remove the anchor field from the scraper
  • Remove the concatenation from the JS client
@bobylito
Copy link
Contributor

On it!

@bobylito bobylito self-assigned this Dec 28, 2015
bobylito pushed a commit that referenced this issue Dec 28, 2015
fix(url): Removes concatenation of URL with hash if it contains a hash
f8a54cc 
FIX #53
This was referenced Dec 28, 2015
Closed
Merged
bobylito pushed a commit that referenced this issue Dec 28, 2015
v1.0.2
c6aa2e3 
<a name="1.0.2"></a>
## [1.0.2](v1.0.1...v1.0.2) (2015-12-28)

### Bug Fixes

* **debut:** do not enable debug by default ([188f49e](188f49e))
* **url:** Removes concatenation of URL with hash if it contains a hash ([348df1c](348df1c)), closes [#53](#53)
* **usage:** fixed usage to match the latest prototype version ([f6edc9e](f6edc9e))
francoischalifour added a commit that referenced this issue Sep 1, 2020
@francoischalifour
chore: release v1.0.0-alpha.20 (#53)
83c7750
@bojanrajh bojanrajh mentioned this issue Mar 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobylito bobylito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelastic @bobylito