fix(insights): control auto sending events w/ isAutoSendingHitsViewEvents
#314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aallam
changed the title
isAutoSendingHitsViewEvents to enable/disable auto sending events
aallam
changed the title
isAutoSendingHitsViewEvents to enable/disable auto sending eventsisAutoSendingHitsViewEvents
Haroenv
reviewed
May 16, 2024
Comment on lines
+166
to
+168
| if isAutoSendingHitsViewEvents { | ||
| searcher.eventTracker.trackView(for: response.hits, eventName: "Hits Viewed") | ||
| } |
There was a problem hiding this comment.
Could we rather send the view events as batches when the hits enter the viewport?
I'm afraid this PR solution creates more noise, especially for Personalization, which is our only product relying on search view events AFAIK. It blurs the signal because there's no guarantee that the user actually sees all the hits from the response.
I created a more correct approach in JavaScript for the Personalization Storefront, perhaps the principle could be reused?
There was a problem hiding this comment.
The library doesn't provide a UI components to display hits as far as I know :/
But indeed, this is something we can investigate later on.
Co-authored-by: Haroen Viaene <[email protected]>
Haroenv
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
isAutoSendingHitsViewEventstoHitsSearcher. If set totrueinsights view events are automatically sent.The parameter defaults to
false.FX-2875