fix(connectRange): use refine instead of cleanUp in metadata (#526)

algolia · Oct 24, 2017 · 1861235 · 1861235
1 parent 1e4ffb2
commit 1861235
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 5 deletions.
diff --git a/packages/react-instantsearch/src/connectors/connectRange.js b/packages/react-instantsearch/src/connectors/connectRange.js
@@ -294,7 +294,8 @@ export default createConnector({
       items.push({
         label: fragments.join(''),
         attributeName: props.attributeName,
-        value: nextState => cleanUp(props, nextState, this.context),
+        value: nextState =>
+          refine(props, nextState, {}, this._currentRange, this.context),
         currentRefinement: {
           min: minValue,
           max: maxValue,

diff --git a/packages/react-instantsearch/src/connectors/connectRange.test.js b/packages/react-instantsearch/src/connectors/connectRange.test.js
@@ -459,7 +459,15 @@ describe('connectRange', () => {
       const searchState = metadata.items[0].value({
         range: { wot: { min: 5 } },
       });
-      expect(searchState).toEqual({ range: {} });
+      expect(searchState).toEqual({
+        page: 1,
+        range: {
+          wot: {
+            min: undefined,
+            max: undefined,
+          },
+        },
+      });
 
       metadata = connect.getMetadata.call(
         {
@@ -532,7 +540,18 @@ describe('connectRange', () => {
         range: { one: { min: 5 }, two: { max: 4 } },
       });
 
-      expect(searchState).toEqual({ range: { two: { max: 4 } } });
+      expect(searchState).toEqual({
+        page: 1,
+        range: {
+          two: {
+            max: 4,
+          },
+          one: {
+            min: undefined,
+            max: undefined,
+          },
+        },
+      });
     });
 
     it('should return the right searchState when clean up', () => {
@@ -699,7 +718,19 @@ describe('connectRange', () => {
       const searchState = metadata.items[0].value({
         indices: { first: { range: { wot: { min: 5 } } } },
       });
-      expect(searchState).toEqual({ indices: { first: { range: {} } } });
+      expect(searchState).toEqual({
+        indices: {
+          first: {
+            page: 1,
+            range: {
+              wot: {
+                min: undefined,
+                max: undefined,
+              },
+            },
+          },
+        },
+      });
 
       metadata = connect.getMetadata.call(
         {
@@ -752,7 +783,20 @@ describe('connectRange', () => {
       });
 
       expect(searchState).toEqual({
-        indices: { first: { range: { two: { max: 4 } } } },
+        indices: {
+          first: {
+            page: 1,
+            range: {
+              one: {
+                min: undefined,
+                max: undefined,
+              },
+              two: {
+                max: 4,
+              },
+            },
+          },
+        },
       });
     });