This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(StarRatings): always show the stars below #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-instantsearch ready! Built with commit 7b2c249 |
|
@samouss nothing seems to happen in the playground now 🤔 |
samouss
force-pushed
the
fix/star-ratings-show-up-only
branch
5 times, most recently
from
1ff6ef9 to
0fcbcf2
Compare
samouss
force-pushed
the
fix/star-ratings-show-up-only
branch
from
0fcbcf2 to
4064e0c
Compare
Haroenv
reviewed
Feb 5, 2018
| isLastSelectableItem: range.length - 1 === index, | ||
| max: limitMax, | ||
| translate, | ||
| createURL, |
There was a problem hiding this comment.
why is refine not in this object anymore?
There was a problem hiding this comment.
Take a look at the signature of buildItem refine is not used. We access the function through the props.
samouss
force-pushed
the
fix/star-ratings-show-up-only
branch
from
4064e0c to
7b2c249
Compare
samouss
added a commit
that referenced
this pull request
Feb 6, 2018
<a name="4.5.0"></a> # [4.5.0](v4.4.2...v4.5.0) (2018-02-06) ### Bug Fixes * **connectRange:** use the same behaviour for currentRefinement in getMetadata ([#923](#923)) ([08917b6](08917b6)) * **connectToggle:** use currentRefinement in metadata instead of the label ([#909](#909)) ([89cae2b](89cae2b)) * **StarRatings:** always show the stars below ([#929](#929)) ([22bf93a](22bf93a)) ### Features * **connectStateResults:** expose isSearchStalled ([#933](#933)) ([f45ba27](f45ba27))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #674
In the current implementation we can have sparse rows when the results only return one facet value or if some numeric filters (ex: rating > 3) are applied. Now all the rows under the highest value are filled. Since the v5 is in
betaI didn't update the tests for avoid to much conflict at the merge. But we should get rid of thereact-test-rendererforenzyme. Same for the component we could move to a SFC after the merge.Before:
After:
You can play with the widget on Storybook.