This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(connectRange): use the same behaviour for currentRefinement in getMetadata #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-instantsearch ready! Built with commit 9a5ad23 |
Haroenv
reviewed
Jan 29, 2018
| @@ -470,7 +470,7 @@ describe('connectRange', () => { | |||
| { | |||
| label: '5 <= wot', | |||
| attributeName: 'wot', | |||
| currentRefinement: { min: 5, max: undefined }, | |||
There was a problem hiding this comment.
so does undefined not work anymore to refine with only min?
There was a problem hiding this comment.
Nope I didn't update the refine behaviour. I only have updated the currentRefinements value provided by the getMetadata function.
samouss
force-pushed
the
fix/connect-range-getmetadata
branch
from
203504e to
a476c13
Compare
samouss
force-pushed
the
fix/connect-range-getmetadata
branch
from
a476c13 to
9a5ad23
Compare
samouss
added a commit
that referenced
this pull request
Feb 6, 2018
<a name="4.5.0"></a> # [4.5.0](v4.4.2...v4.5.0) (2018-02-06) ### Bug Fixes * **connectRange:** use the same behaviour for currentRefinement in getMetadata ([#923](#923)) ([08917b6](08917b6)) * **connectToggle:** use currentRefinement in metadata instead of the label ([#909](#909)) ([89cae2b](89cae2b)) * **StarRatings:** always show the stars below ([#929](#929)) ([22bf93a](22bf93a)) ### Features * **connectStateResults:** expose isSearchStalled ([#933](#933)) ([f45ba27](f45ba27))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #920
We provide two different values for the
currentRefinementingetProvidedProps&getMetadata. In the first case we "normalize" the value with the range, in the latter we pass the raw values. It can lead to some issues when the user use thecurrentRefinementfrom theconnectCurrentRefinementsince the values aren't aligned.Edit: At some point we should avoid to "normalize" the
currentRefinementwith the range from the connector. Passing the raw values to the view and let it decide which value to render is more flexible. It's a bit more work to do in the view but the connector will be more reusable (ex: We can implement a "correct" behaviour forRatingMenu).