This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 386
feat(geo): add Marker & HTMLMarker interactions [PART-8] #1227
Merged
samouss
merged 26 commits into
feat/geo-part-7-custom-marker
from
feat/geo-part-8-marker-options
Jun 20, 2018
Merged
feat(geo): add Marker & HTMLMarker interactions [PART-8] #1227
samouss
merged 26 commits into
feat/geo-part-7-custom-marker
from
feat/geo-part-8-marker-options
Jun 20, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for react-instantsearch ready! Built with commit a330dee https://deploy-preview-1227--react-instantsearch.netlify.com |
b7e0583
to
3f34497
Compare
4c00daf
to
7387ab0
Compare
3f34497
to
b13e5d0
Compare
5e77b01
to
ace15e8
Compare
b270999
to
0d7a7e4
Compare
ace15e8
to
7b63aa2
Compare
0d7a7e4
to
f7477f9
Compare
7b63aa2
to
d1267d2
Compare
* feat(geo): add docs [PART-10] (#1289)
samouss
added a commit
that referenced
this pull request
Jun 20, 2018
samouss
added a commit
that referenced
this pull request
Jun 20, 2018
samouss
added a commit
that referenced
this pull request
Jun 20, 2018
* feat(geo): add Control component [PART-5] (#1205) * feat(geo): refactor & external update [PART-6] (#1207) * feat(geo): custom Marker [PART-7] (#1214) * feat(geo): add Marker & HTMLMarker interactions [PART-8] (#1227) * feat(geo): add stories [PART-9] (#1236) * feat(geo): add docs [PART-10] (#1289)
samouss
added a commit
that referenced
this pull request
Jun 20, 2018
* feat(geo): add Redo component [PART-4] (#1201) * feat(geo): add Control component [PART-5] (#1205) * feat(geo): refactor & external update [PART-6] (#1207) * feat(geo): custom Marker [PART-7] (#1214) * feat(geo): add Marker & HTMLMarker interactions [PART-8] (#1227) * feat(geo): add stories [PART-9] (#1236) * feat(geo): add docs [PART-10] (#1289)
samouss
added a commit
that referenced
this pull request
Jun 20, 2018
* feat(geo): add refine on interaction [PART-3] (#1192) * feat(geo): add Redo component [PART-4] (#1201) * feat(geo): add Control component [PART-5] (#1205) * feat(geo): refactor & external update [PART-6] (#1207) * feat(geo): custom Marker [PART-7] (#1214) * feat(geo): add Marker & HTMLMarker interactions [PART-8] (#1227) * feat(geo): add stories [PART-9] (#1236) * feat(geo): add docs [PART-10] (#1289)
samouss
added a commit
that referenced
this pull request
Jun 21, 2018
* feat(geo): add simple GoogleMaps widget [PART-2] (#1189) * feat(geo): add refine on interaction [PART-3] (#1192) * feat(geo): add Redo component [PART-4] (#1201) * feat(geo): add Control component [PART-5] (#1205) * feat(geo): refactor & external update [PART-6] (#1207) * feat(geo): custom Marker [PART-7] (#1214) * feat(geo): add Marker & HTMLMarker interactions [PART-8] (#1227) * feat(geo): add stories [PART-9] (#1236) * feat(geo): add docs [PART-10] (#1289)
samouss
added a commit
that referenced
this pull request
Jul 4, 2018
<a name="5.2.0"></a> # [5.2.0](v5.2.0-beta.2...v5.2.0) (2018-07-04) ### Bug Fixes * **translatable:** avoid create a new function on every render ([#1383](#1383)) ([1285b3b](1285b3b)) ### Features * **core:** export translatable ([#1351](#1351)) ([6d5a89d](6d5a89d)) * **maps:** add connector & widget ([#1171](#1171)) ([16e288a](16e288a)), closes [#1189](#1189) [#1192](#1192) [#1201](#1201) [#1205](#1205) [#1207](#1207) [#1214](#1214) [#1227](#1227) [#1236](#1236) [#1289](#1289)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the eighth part of the GeoSearch widget. The PR introduces the ability to attach event handlers on both markers (
<Marker>
&<HTMLMarker>
). We also moved the options to be top level for<GeoSearch>
,<Marker>
,<HTMLMarker>
. There is no more themapOptions
&options
props. You can pass the option directly to the component.This PR includes:
utils
: create some utility functions to register the listeners, filter props, etc...createHTMLMarker
: update theaddListener
signature to match the one from Google Maps. It means that we can register & remove events in the same way for both implementations.<GeoSearch>
: remove themapOptions
prop, now you can pass the options directly to the component. They will be forward to<GoogleMaps>
.<Marker>
: we can now attach event listener to the marker like any other React element. But only a subset of events are available. The ones available are the ones implemented by Google Maps. We also remove theoptions
prop, now you can pass the options directly to the component.<HTMLMarker>
: we can now attach event listener to the marker like any other React element. All the regular mouse events are available (exceptdrag
). We also remove theoptions
prop, now you can pass the options directly to the component.Usage
Result
You can use the widget in Storybook.