This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(core/InstantSearch): update algoliaClient when it change #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
reviewed
Apr 27, 2017
|
Thank you for this quick response, i just added the unit test |
|
Ok thanks |
|
@Mystraht Thank you for your contribution :) |
mthuret
pushed a commit
that referenced
this pull request
May 2, 2017
<a name="4.0.0-beta.5"></a> # [4.0.0-beta.5](v4.0.0-beta.4...v4.0.0-beta.5) (2017-05-02) ### Bug Fixes * **connectAutoComplete:** allow usage with hits from a single index (#75) ([8b3b358](8b3b358)), closes [#74](#74) * **InstantSearch:** update algoliaClient when it change (#70) ([9e97dbd](9e97dbd))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ApiKey parameter is not changed in search query when InstantSearch component is updated with new apiKey props.
Algolia client is updated with new values if appId or apiKey is changed (at createInstantSearch.js:39) but helper in InstantSearchManager (created in InstantSearch component) is not updated.
Result
I created component that render InstantSearch with apiKey "exampleApiKey1" then i changed component state (with setTimeout for the example) to render InstantSearch again but with a new apiKey props. (exampleApiKey2)
Without my fix, ajax call is always called with exampleApiKey1
http://image.prntscr.com/image/c5a1670088ad4e7b9edfaff72ec9479b.png
With my fix, ajax get is called with exampleApiKey1 then exampleApiKey2 after rendering with the new props (see screens)
http://image.prntscr.com/image/a68d4384ff16488f83813e98b91478cb.png
Thanks