fix: manually check pending requests #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millotp
approved these changes
Oct 19, 2022
Comment on lines
+107
to
+120
| while ( | ||
| this.page.pendingRequests > 0 && | ||
| Date.now() - startWaitTime < timeBudget | ||
| ) { | ||
| log.debug( | ||
| { pageUrl: this.page.ref?.url() }, | ||
| `Waiting for ${ | ||
| this.page.pendingRequests | ||
| } requests to complete... WaitTime:${ | ||
| Date.now() - startWaitTime | ||
| }, timeBudget: ${timeBudget}` | ||
| ); | ||
| await setTimeout(1000); | ||
| } |
There was a problem hiding this comment.
do we have a timeout for this ?
There was a problem hiding this comment.
Or maybe a for loop instead of while with limited iteration
There was a problem hiding this comment.
So the timeBudget is always set with a max: https://github.com/algolia/renderscript/blob/master/src/lib/tasks/Task.ts#L68, and the max by default is 20s: https://github.com/algolia/renderscript/blob/master/src/lib/constants.ts#L27
On the Crawler side, we also don't allow to configure it with more than 20s
algolia-bot
added a commit
that referenced
this pull request
Oct 19, 2022
## [2.1.22](v2.1.21...v2.1.22) (2022-10-19) ### Bug Fixes * manually check pending requests ([#654](#654)) ([21b6a80](21b6a80))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With noticed that some pages are not fully rendered.
After some investigation, it appears that it's because we render the page too soon, while all requests have not returned yet.
This appear to be caused by some flakyness in the
waitForLoadState('networkidle')feature, confirmed by some Playwright contributors:To bypass this problem, this PR does something similar than in the suggested gist: counting pending requests, and waiting for the number to get back to 0 before rendering the page.
Changes
pendingrequests to the metrics, increased on'request'and decreased onrequestfailedorrequestfinished