Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme updates #296

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Readme updates #296

merged 3 commits into from
Apr 14, 2022

Conversation

barnjamin
Copy link
Contributor

No description provided.

@barnjamin barnjamin marked this pull request as ready for review February 23, 2022 13:55
algochoi
algochoi approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good change. The existing examples could be outdated and may confuse new people - I'm also in favor of doing this in the Java SDK as well.

@barnjamin barnjamin merged commit 8c69c29 into develop Apr 14, 2022
@michaeldiamant michaeldiamant deleted the readme-updates branch April 27, 2022 16:33
@algobarb algobarb mentioned this pull request Apr 28, 2022
Merged
@onetechnical onetechnical mentioned this pull request Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algochoi algochoi algochoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barnjamin @algochoi @onetechnical