Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Foreign* args to AddMethodCallParams #318

Merged
merged 4 commits into from
May 16, 2022
Merged

Adding Foreign* args to AddMethodCallParams #318

merged 4 commits into from
May 16, 2022

Conversation

barnjamin
Copy link
Contributor

@barnjamin barnjamin commented May 13, 2022 •
edited
Loading

Addresses #319

@barnjamin
adding fields to AddMethodCallPArams to allow manual addition of fore…
7d10be5 
…ign args not present in the method signature
@barnjamin barnjamin requested a review from algoidurovic May 13, 2022 14:38
@barnjamin barnjamin force-pushed the manual-foreign-args branch from 58c01a8 to 99f7fae Compare May 13, 2022 14:41
@barnjamin barnjamin requested a review from winder May 13, 2022 14:57
jasonpaulos
jasonpaulos reviewed May 13, 2022
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a testing suggestion

future/atomicTransactionComposer_test.go Outdated Show resolved Hide resolved
@barnjamin barnjamin requested a review from jasonpaulos May 13, 2022 17:55
jasonpaulos
jasonpaulos approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending the build passing, looks good to me

algoidurovic
algoidurovic approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@algoidurovic algoidurovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@barnjamin barnjamin merged commit 2b8c15b into develop May 16, 2022
@barnjamin barnjamin deleted the manual-foreign-args branch May 16, 2022 14:21
@barnjamin barnjamin mentioned this pull request May 16, 2022
Closed
@onetechnical onetechnical mentioned this pull request Jun 2, 2022
Merged
@algochoi algochoi mentioned this pull request Dec 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonpaulos jasonpaulos jasonpaulos approved these changes

@algoidurovic algoidurovic algoidurovic approved these changes

@winder winder Awaiting requested review from winder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barnjamin @jasonpaulos @algoidurovic