Tests: Support for new cucumber app call txn decoding test #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
commented
Nov 8, 2022
jasonpaulos
commented
Nov 8, 2022
| @@ -377,7 +377,6 @@ func FeatureContext(s *godog.Suite) { | |||
| s.Step(`^I build a payment transaction with sender "([^"]*)", receiver "([^"]*)", amount (\d+), close remainder to "([^"]*)"$`, iBuildAPaymentTransactionWithSenderReceiverAmountCloseRemainderTo) | |||
| s.Step(`^I create a transaction with signer with the current transaction\.$`, iCreateATransactionWithSignerWithTheCurrentTransaction) | |||
| s.Step(`^I append the current transaction with signer to the method arguments array\.$`, iAppendTheCurrentTransactionWithSignerToTheMethodArgumentsArray) | |||
| s.Step(`^the decoded transaction should equal the original$`, theDecodedTransactionShouldEqualTheOriginal) | |||
There was a problem hiding this comment.
This step was registered twice, the other time being
go-algorand-sdk/test/transactions_test.go
Line 191 in 60292fb
4 tasks
jasonpaulos
changed the title
algochoi
approved these changes
Nov 8, 2022
| @@ -377,7 +377,6 @@ func FeatureContext(s *godog.Suite) { | |||
| s.Step(`^I build a payment transaction with sender "([^"]*)", receiver "([^"]*)", amount (\d+), close remainder to "([^"]*)"$`, iBuildAPaymentTransactionWithSenderReceiverAmountCloseRemainderTo) | |||
| s.Step(`^I create a transaction with signer with the current transaction\.$`, iCreateATransactionWithSignerWithTheCurrentTransaction) | |||
| s.Step(`^I append the current transaction with signer to the method arguments array\.$`, iAppendTheCurrentTransactionWithSignerToTheMethodArgumentsArray) | |||
| s.Step(`^the decoded transaction should equal the original$`, theDecodedTransactionShouldEqualTheOriginal) | |||
Co-authored-by: algochoi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for algorand/algorand-sdk-testing#248
Note: the code exported by this library does not suffer from the same bug as algorand/js-algorand-sdk#688, but some changes were needed to get the test to pass properly.
I don't believe this PR necessitates a patch release.