-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable query parameters runtime data structures. #873
Conversation
d199e72
to
716aceb
Compare
Added a runtime data structure that can be used to disable endpoints and query parameters if needed. Currently the data structure enables everything, so no functional change has occured to the user.
716aceb
to
1a447ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, this approach is a lot nicer than I realized from your description. I had some specific suggestions that might reduce the boilerplate even more, let me know what you think.
34405fc
to
7088cbf
Compare
d59afac
to
fac23d8
Compare
fac23d8
to
40b3edc
Compare
95771e9
to
8b737df
Compare
Codecov Report
@@ Coverage Diff @@
## develop #873 +/- ##
===========================================
- Coverage 59.02% 58.73% -0.30%
===========================================
Files 37 38 +1
Lines 4425 4495 +70
===========================================
+ Hits 2612 2640 +28
- Misses 1499 1528 +29
- Partials 314 327 +13
Continue to review full report at Codecov.
|
Resolves algorand/go-algorand#3581
Added a runtime data structure that can be used to disable endpoints and
query parameters if needed.
Currently the data structure enables everything, so no functional change
has occurred to the user.