Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable query parameters runtime data structures. #873

Merged
merged 13 commits into from
Feb 16, 2022

Conversation

AlgoStephenAkiki
Copy link
Contributor

@AlgoStephenAkiki AlgoStephenAkiki commented Feb 9, 2022

Resolves algorand/go-algorand#3581

Added a runtime data structure that can be used to disable endpoints and
query parameters if needed.

Currently the data structure enables everything, so no functional change
has occurred to the user.

@AlgoStephenAkiki AlgoStephenAkiki force-pushed the feature/3581-create-runtime branch from d199e72 to 716aceb Compare February 9, 2022 20:23
Added a runtime data structure that can be used to disable endpoints and
query parameters if needed.

Currently the data structure enables everything, so no functional change
has occured to the user.
@AlgoStephenAkiki AlgoStephenAkiki force-pushed the feature/3581-create-runtime branch from 716aceb to 1a447ce Compare February 9, 2022 20:36
@AlgoStephenAkiki AlgoStephenAkiki marked this pull request as ready for review February 9, 2022 21:04
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, this approach is a lot nicer than I realized from your description. I had some specific suggestions that might reduce the boilerplate even more, let me know what you think.

api/disabled_parameters_test.go Outdated Show resolved Hide resolved
api/disabled_parameters_test.go Outdated Show resolved Hide resolved
api/disabled_parameters_test.go Outdated Show resolved Hide resolved
api/handlers.go Outdated Show resolved Hide resolved
api/server.go Show resolved Hide resolved
api/disabled_parameters.go Outdated Show resolved Hide resolved
api/disabled_parameters.go Outdated Show resolved Hide resolved
api/disabled_parameters.go Outdated Show resolved Hide resolved
api/disabled_parameters.go Outdated Show resolved Hide resolved
@AlgoStephenAkiki AlgoStephenAkiki force-pushed the feature/3581-create-runtime branch from 34405fc to 7088cbf Compare February 10, 2022 14:39
api/disabled_parameters.go Show resolved Hide resolved
api/disabled_parameters.go Outdated Show resolved Hide resolved
api/disabled_parameters.go Show resolved Hide resolved
api/disabled_parameters.go Show resolved Hide resolved
api/handlers.go Show resolved Hide resolved
@AlgoStephenAkiki AlgoStephenAkiki force-pushed the feature/3581-create-runtime branch from d59afac to fac23d8 Compare February 14, 2022 00:39
@AlgoStephenAkiki AlgoStephenAkiki force-pushed the feature/3581-create-runtime branch from fac23d8 to 40b3edc Compare February 14, 2022 00:41
@AlgoStephenAkiki AlgoStephenAkiki force-pushed the feature/3581-create-runtime branch from 95771e9 to 8b737df Compare February 14, 2022 01:32
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2022

Codecov Report

Merging #873 (873b8d8) into develop (0837fac) will decrease coverage by 0.29%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #873      +/-   ##
===========================================
- Coverage    59.02%   58.73%   -0.30%     
===========================================
  Files           37       38       +1     
  Lines         4425     4495      +70     
===========================================
+ Hits          2612     2640      +28     
- Misses        1499     1528      +29     
- Partials       314      327      +13     
Impacted Files Coverage Δ
api/server.go 0.00% <0.00%> (ø)
api/handlers.go 69.21% <3.70%> (-3.67%) ⬇️
api/disabled_parameters.go 69.23% <69.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0837fac...873b8d8. Read the comment docs.

api/handlers.go Outdated Show resolved Hide resolved
api/handlers.go Outdated Show resolved Hide resolved
@winder winder self-requested a review February 15, 2022 22:06
api/disabled_parameters_test.go Outdated Show resolved Hide resolved
@winder winder merged commit 3cafaad into develop Feb 16, 2022
@winder winder changed the title Initial Runtime data structures Configurable query parameters runtime data structures. Feb 16, 2022
@winder winder deleted the feature/3581-create-runtime branch February 16, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Runtime Data Structures
4 participants