Temporarily revert to inline glob search #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorand#888 introduces a bug due to bash's ordering of brace and parameter expansion. The commit supports parameter expansion at the expense of dropping the environment variable. I'll restore external configuration in a subsequent PR.
Codecov Report
@@ Coverage Diff @@
## develop #889 +/- ##
========================================
Coverage 58.73% 58.73%
========================================
Files 38 38
Lines 4495 4495
========================================
Hits 2640 2640
Misses 1528 1528
Partials 327 327 Continue to review full report at Codecov.
|
winder
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#888 introduces a bug due to bash's ordering of brace and parameter expansion. The commit supports parameter expansion at the expense of dropping the environment variable.
I'll restore external configuration in a subsequent PR.
Test Plan
Running the script shows inclusion of expanded test files: script_output.txt