Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Parameters in REST API #892

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

AlgoStephenAkiki
Copy link
Contributor

Resolves #3582

Puts in the infrastructure and disables certain parameters in the REST
API for poor performing queries.

@AlgoStephenAkiki AlgoStephenAkiki force-pushed the feature/3582-determine-disabled-params branch 2 times, most recently from 34b22a4 to 7d22922 Compare February 22, 2022 21:14
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple nits

api/disabled_parameters.go Outdated Show resolved Hide resolved
api/disabled_parameters.go Show resolved Hide resolved
api/disabled_parameters.go Outdated Show resolved Hide resolved
Resolves #3582

Puts in the infrastructure and disables certain parameters in the REST
API for poor performing queries.
@AlgoStephenAkiki AlgoStephenAkiki force-pushed the feature/3582-determine-disabled-params branch from 1eba1c8 to cf694a8 Compare February 22, 2022 22:40
@codecov-commenter
Copy link

Codecov Report

Merging #892 (cf694a8) into develop (6b0ebfd) will decrease coverage by 0.14%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #892      +/-   ##
===========================================
- Coverage    58.73%   58.58%   -0.15%     
===========================================
  Files           38       38              
  Lines         4495     4552      +57     
===========================================
+ Hits          2640     2667      +27     
- Misses        1528     1555      +27     
- Partials       327      330       +3     
Impacted Files Coverage Δ
api/server.go 0.00% <0.00%> (ø)
api/disabled_parameters.go 58.69% <46.55%> (-10.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b0ebfd...cf694a8. Read the comment docs.

@AlgoStephenAkiki AlgoStephenAkiki marked this pull request as ready for review February 24, 2022 15:31
@AlgoStephenAkiki AlgoStephenAkiki merged commit 1216e79 into develop Feb 24, 2022
@AlgoStephenAkiki AlgoStephenAkiki deleted the feature/3582-determine-disabled-params branch February 24, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants