Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unlimited assets: backwards-compatible JSON encodings for account data #896

Merged
merged 4 commits into from
Feb 24, 2022

Conversation

cce
Copy link
Contributor

@cce cce commented Feb 23, 2022

Summary

This restores the old JSON field names in the account data blob.

Test Plan

Existing tests should pass.

idb/postgres/internal/encoding/types.go Outdated Show resolved Hide resolved
idb/postgres/internal/encoding/encoding.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feature/unlimited-assets@ae96643). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                     Coverage Diff                     @@
##             feature/unlimited-assets     #896   +/-   ##
===========================================================
  Coverage                            ?   58.41%           
===========================================================
  Files                               ?       40           
  Lines                               ?     4773           
  Branches                            ?        0           
===========================================================
  Hits                                ?     2788           
  Misses                              ?     1644           
  Partials                            ?      341           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae96643...fe41b51. Read the comment docs.

@cce cce merged commit 76faddd into feature/unlimited-assets Feb 24, 2022
@cce cce deleted the feature/unlimited-assets-json-fields branch February 24, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants