Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix failing e2e test #899

Merged
merged 4 commits into from
Feb 25, 2022
Merged

fix failing e2e test #899

merged 4 commits into from
Feb 25, 2022

Conversation

shiqizng
Copy link
Contributor

@shiqizng shiqizng commented Feb 24, 2022 •
edited
Loading

Summary

make e2e fails with nil pointer error with a new s3 artifact,

output from 'go' 'run' 'cmd/e2equeries/main.go' '-pg' 'host=e2e-db port=5432 user=algorand password=algorand dbname=indexer_db sslmode=disable' '-q'
panic: runtime error: invalid memory address or nil pointer dereference
e2e_1     | [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xf94ac9]

This PR fixes this issue.

Test Plan

run make e2e to validate test completes without error.

@shiqizng shiqizng requested a review from winder February 24, 2022 19:23
winder
winder reviewed Feb 24, 2022
View reviewed changes
cmd/e2equeries/main.go Outdated Show resolved Hide resolved
winder
winder reviewed Feb 24, 2022
View reviewed changes
cmd/e2equeries/main.go
@@ -63,7 +65,7 @@ func main() {
}
if !foundRekey {
// this will report the error in a handy way
printAccountQuery(db, idb.AccountQueryOptions{EqualToAuthAddr: rekeyedAuthAddrs[0][:], Limit: 1})
printAccountQuery(db, idb.AccountQueryOptions{EqualToAuthAddr: rekeyedAuthAddrs[0][:], Limit: 0})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What error is this supposed to be reporting?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I see it. This triggers the "came up short" error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@winder winder mentioned this pull request Feb 24, 2022
Closed
@codecov-commenter
Copy link

Codecov Report

Merging #899 (7764245) into develop (6b0ebfd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #899   +/-   ##
========================================
  Coverage    58.73%   58.73%           
========================================
  Files           38       38           
  Lines         4495     4495           
========================================
  Hits          2640     2640           
  Misses        1528     1528           
  Partials       327      327

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b0ebfd...7764245. Read the comment docs.

@winder winder merged commit 2aad7db into develop Feb 25, 2022
@winder winder deleted the fix/e2e branch February 25, 2022 22:00
@algobarb algobarb mentioned this pull request Mar 10, 2022
Merged
@algobarb algobarb mentioned this pull request Apr 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winder winder winder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shiqizng @codecov-commenter @winder