REST API: count include-all results when checking max resources limit #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlgoStephenAkiki
approved these changes
Feb 25, 2022
winder
reviewed
Feb 25, 2022
|
|
||
| if opts.IncludeDeleted { | ||
| // if IncludeDeleted is set, need to construct a query (preserving filters) to count deleted values that would be returned from | ||
| // asset, app, account_asset, account_app | ||
| o.CountOnly = true | ||
| countOnly = true |
There was a problem hiding this comment.
For the resource limit check, don't we always want this to be true?
There was a problem hiding this comment.
Nevermind, I forgot that in that case we are looking up the data from the account.
winder
approved these changes
Feb 25, 2022
Codecov Report
@@ Coverage Diff @@
## feature/unlimited-assets #901 +/- ##
===========================================================
Coverage ? 59.07%
===========================================================
Files ? 42
Lines ? 5644
Branches ? 0
===========================================================
Hits ? 3334
Misses ? 1868
Partials ? 442 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handle include-all when checking max resources limit by adding option to perform count queries to buildAccountQuery rather than fetch full results. Follow-up to #872
Test Plan
Extended TestAccountMaxResultsLimit to create and destroy assets and apps, check behavior of include-all with limits.