Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Viewing of Disabled Params #902

Merged
merged 4 commits into from
Mar 1, 2022

Conversation

AlgoStephenAkiki
Copy link
Contributor

@AlgoStephenAkiki AlgoStephenAkiki commented Feb 28, 2022

Resolves #3583

Add a new subcommand "algorand-indexer api-config" to show current
config

@AlgoStephenAkiki AlgoStephenAkiki force-pushed the feature/3582-determine-disabled-params branch 2 times, most recently from c70f237 to bf5d38a Compare February 28, 2022 16:03
Resolves #3583

Add a new subcommand "algorand-indexer api-config" to show current
config
@AlgoStephenAkiki AlgoStephenAkiki force-pushed the feature/3582-determine-disabled-params branch from bf5d38a to 0e140b7 Compare February 28, 2022 16:05
@AlgoStephenAkiki AlgoStephenAkiki marked this pull request as ready for review February 28, 2022 16:54
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes needed, and an optional suggestion to consider.

README.md Outdated Show resolved Hide resolved
api/disabled_parameters.go Show resolved Hide resolved
api/server.go Outdated Show resolved Hide resolved
cmd/algorand-indexer/api_config.go Outdated Show resolved Hide resolved
cmd/algorand-indexer/main.go Outdated Show resolved Hide resolved
@AlgoStephenAkiki AlgoStephenAkiki force-pushed the feature/3582-determine-disabled-params branch from 1f02c51 to d6772b3 Compare March 1, 2022 19:38
@AlgoStephenAkiki AlgoStephenAkiki requested a review from winder March 1, 2022 19:39
@AlgoStephenAkiki AlgoStephenAkiki requested a review from winder March 1, 2022 20:56
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2022

Codecov Report

Merging #902 (dc0bda8) into develop (8d85bf4) will decrease coverage by 0.65%.
The diff coverage is 3.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #902      +/-   ##
===========================================
- Coverage    58.69%   58.04%   -0.66%     
===========================================
  Files           39       40       +1     
  Lines         4581     4636      +55     
===========================================
+ Hits          2689     2691       +2     
- Misses        1561     1614      +53     
  Partials       331      331              
Impacted Files Coverage Δ
api/disabled_parameters.go 44.62% <0.00%> (-14.07%) ⬇️
api/server.go 0.00% <0.00%> (ø)
cmd/algorand-indexer/daemon.go 24.59% <0.00%> (-0.41%) ⬇️
cmd/algorand-indexer/api_config.go 4.16% <4.16%> (ø)
cmd/algorand-indexer/main.go 34.54% <100.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d85bf4...dc0bda8. Read the comment docs.

@AlgoStephenAkiki AlgoStephenAkiki merged commit 8b58e4b into develop Mar 1, 2022
@AlgoStephenAkiki AlgoStephenAkiki deleted the feature/3582-determine-disabled-params branch March 1, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants