Fix/metrics #908
Closed
Fix/metrics #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #908 +/- ##
========================================
Coverage 58.04% 58.04%
========================================
Files 40 40
Lines 4636 4636
========================================
Hits 2691 2691
Misses 1614 1614
Partials 331 331 Continue to review full report at Codecov.
|
winder
force-pushed
the
fix/metrics
branch
2 times, most recently
from
966721f to
35e77f8
Compare
|
I added a small change to avoid hard coding the metric name in the processing code. The TPS calculation is also incorrect, I didn't notice earlier but switching from counter to a gauge means that we lose data if scraping doesn't happen for every block. Here is something that seems to work, but it must break the monitoring dashboard. #909 |
|
closing this issue. it's not needed anymore after #913 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Metrics changes from monitoring dashboard updates broke the metrics calculation in block generator. This PR fixes this error,
error writing metrics (imported_tx_per_block): metric incomplete or not found: imported_tx_per_blockTest Plan
Execute block-generator runner to validate the error is gone and check that metrics report is complete.