Bugfix: Return all inner transactions are returned for logs endpoint. #915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes deduplication when returning inner transaction results. Without this check, a query that should return all matched inner txns will return only the first result as inner txns all share the same txID as their root txn. Currently, this only affects the
applications/ID/logs
endpoint, as inner txns are otherwise "rolled up" and any queries matches on inner txns return its root txn anyway.Test Plan
Added test case to check that results are returned properly without deduplication based on txID when logs are queried. Tested locally on sandbox as well, and multiple logs with same txIDs show up.
Prior to this change, the added unit test will only return the first inner txn's logs and fail.