-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: npm runs ci
instead on install
when CI flag is present or passed explicitly`
#605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilcampbell
approved these changes
Jan 13, 2025
@@ -102,5 +102,11 @@ def poetry() -> None: | |||
@bootstrap_group.command( | |||
"npm", short_help="Runs `npm install` in the current working directory to install Node.js dependencies." | |||
) | |||
def npm() -> None: | |||
bootstrap_npm(Path.cwd()) | |||
@click.option( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that change apply to all
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all
already has --ci, --interactive/--no-interactive options where (--ci is equivalent to --no-interactive).
e55860e
to
01dcef9
Compare
…assed explicitly`
01dcef9
to
cb91e80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
bootstrap
group to runnpm ci
when CI is present as env var and set to true or passed via--ci
flag (or--non-interactive/--ci
inall
command)