chore: address linting errors after dev tooling update

algorandfoundation · Oct 17, 2024 · fb0b057 · fb0b057 · github-actions · Oct 17, 2024
1 parent 97ccac8
commit fb0b057
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 15 deletions.
diff --git a/.github/workflows/check-python.yaml b/.github/workflows/check-python.yaml
@@ -40,7 +40,7 @@ jobs:
       - name: Check linting with Ruff
         run: |
           # stop the build if there are Python syntax errors or undefined names
-          poetry run ruff .
+          poetry run ruff check .
 
       - name: Check types with mypy
         run: poetry run mypy

diff --git a/pyproject.toml b/pyproject.toml
@@ -121,7 +121,7 @@ target-version = "py310"
 allow-star-arg-any = true
 suppress-none-returning = true
 
-[tool.ruff.per-file-ignores]
+[tool.ruff.lint.per-file-ignores]
 "src/algokit_utils/beta/*" = ["ERA001", "E501", "PLR0911"]
 "path/to/file.py" = ["E402"]
 

diff --git a/src/algokit_utils/account.py b/src/algokit_utils/account.py
@@ -39,14 +39,14 @@ def get_account_from_mnemonic(mnemonic: str) -> Account:
 
 def create_kmd_wallet_account(kmd_client: "KMDClient", name: str) -> Account:
     """Creates a wallet with specified name"""
-    wallet_id = kmd_client.create_wallet(name, "")["id"]  # type: ignore[no-untyped-call]
-    wallet_handle = kmd_client.init_wallet_handle(wallet_id, "")  # type: ignore[no-untyped-call]
-    kmd_client.generate_key(wallet_handle)  # type: ignore[no-untyped-call]
+    wallet_id = kmd_client.create_wallet(name, "")["id"]
+    wallet_handle = kmd_client.init_wallet_handle(wallet_id, "")
+    kmd_client.generate_key(wallet_handle)
 
-    key_ids: list[str] = kmd_client.list_keys(wallet_handle)  # type: ignore[no-untyped-call]
+    key_ids: list[str] = kmd_client.list_keys(wallet_handle)
     account_key = key_ids[0]
 
-    private_account_key = kmd_client.export_key(wallet_handle, "", account_key)  # type: ignore[no-untyped-call]
+    private_account_key = kmd_client.export_key(wallet_handle, "", account_key)
     return get_account_from_mnemonic(from_private_key(private_account_key))  # type: ignore[no-untyped-call]
 
 
@@ -116,15 +116,15 @@ def get_kmd_wallet_account(
     predicate: "Callable[[dict[str, Any]], bool] | None" = None,
 ) -> Account | None:
     """Returns wallet matching specified name and predicate or None if not found"""
-    wallets: list[dict] = kmd_client.list_wallets()  # type: ignore[no-untyped-call]
+    wallets: list[dict] = kmd_client.list_wallets()
 
     wallet = next((w for w in wallets if w["name"] == name), None)
     if wallet is None:
         return None
 
     wallet_id = wallet["id"]
-    wallet_handle = kmd_client.init_wallet_handle(wallet_id, "")  # type: ignore[no-untyped-call]
-    key_ids: list[str] = kmd_client.list_keys(wallet_handle)  # type: ignore[no-untyped-call]
+    wallet_handle = kmd_client.init_wallet_handle(wallet_id, "")
+    key_ids: list[str] = kmd_client.list_keys(wallet_handle)
     matched_account_key = None
     if predicate:
         for key in key_ids:
@@ -138,7 +138,7 @@ def get_kmd_wallet_account(
     if not matched_account_key:
         return None
 
-    private_account_key = kmd_client.export_key(wallet_handle, "", matched_account_key)  # type: ignore[no-untyped-call]
+    private_account_key = kmd_client.export_key(wallet_handle, "", matched_account_key)
     return get_account_from_mnemonic(from_private_key(private_account_key))  # type: ignore[no-untyped-call]
 
 

diff --git a/src/algokit_utils/application_client.py b/src/algokit_utils/application_client.py
@@ -233,7 +233,7 @@ def prepare(
     ) -> "ApplicationClient":
         """Creates a copy of this ApplicationClient, using the new signer, sender and app_id values if provided.
         Will also substitute provided template_values into the associated app_spec in the copy"""
-        new_client: "ApplicationClient" = copy.copy(self)
+        new_client: ApplicationClient = copy.copy(self)
         new_client._prepare(  # noqa: SLF001
             new_client, signer=signer, sender=sender, app_id=app_id, template_values=template_values
         )

diff --git a/src/algokit_utils/beta/composer.py b/src/algokit_utils/beta/composer.py
@@ -567,7 +567,7 @@ def _is_abi_value(self, x: bool | float | str | bytes | list | TxnParams) -> boo
 
         return isinstance(x, bool | int | float | str | bytes)
 
-    def _build_method_call(
+    def _build_method_call(  # noqa: C901, PLR0912
         self, params: MethodCallParams, suggested_params: algosdk.transaction.SuggestedParams
     ) -> list[TransactionWithSigner]:
         method_args = []
@@ -633,7 +633,7 @@ def _build_method_call(
 
         return self._build_atc(method_atc)
 
-    def _build_txn(
+    def _build_txn(  # noqa: C901, PLR0912
         self,
         txn: TransactionWithSigner | TxnParams | AtomicTransactionComposer,
         suggested_params: algosdk.transaction.SuggestedParams,

diff --git a/src/algokit_utils/deploy.py b/src/algokit_utils/deploy.py
@@ -867,7 +867,7 @@ def _convert_deploy_args(
     signer: TransactionSigner | None,
     sender: str | None,
 ) -> tuple[ABIMethod | bool | None, ABIArgsDict, CreateCallParameters]:
-    args = _args.__dict__ if isinstance(_args, DeployCallArgs) else (_args or {})
+    args = _args.__dict__ if isinstance(_args, DeployCallArgs) else dict(_args or {})
 
     # return most derived type, unused parameters are ignored
     parameters = CreateCallParameters(
File	Stmts	Miss	Cover	Missing
src/algokit_utils
_debugging.py	140	7	95%	20, 41, 76, 80, 89, 129, 157
_ensure_funded.py	69	1	99%	99
_transfer.py	67	3	96%	13, 76–77
account.py	85	13	85%	14–17, 61–65, 96, 109, 136, 139, 183
application_client.py	528	77	85%	59–60, 167, 172, 201, 313, 318–319, 321, 323, 788, 803, 821–824, 914, 954, 966, 979, 1021, 1081–1087, 1091–1096, 1098, 1134, 1141, 1254, 1284, 1298, 1336–1338, 1340, 1350–1407, 1418–1423, 1443–1446
application_specification.py	97	11	89%	92, 94, 193–202, 206
asset.py	79	5	94%	9, 27–30
common.py	13	1	92%	13
config.py	51	18	65%	38–39, 50, 55, 60, 64–69, 100–109
deploy.py	463	26	94%	30–33, 168, 172–173, 190, 205, 246, 362–363, 418, 429–437, 454–457, 467, 475, 668–669, 693
dispenser_api.py	82	12	85%	112–113, 117–120, 155–157, 176–178
logic_error.py	39	2	95%	8, 31
models.py	131	6	95%	45, 50–52, 61–62
network_clients.py	63	3	95%	93–94, 125
src/algokit_utils/beta
account_manager.py	55	14	75%	39–40, 64, 123–130, 183–187, 198–200
algorand_client.py	101	15	85%	111–112, 121–122, 143–145, 154–155, 224, 259, 274, 290, 303, 319
client_manager.py	37	10	73%	40, 61–63, 68–70, 75–78
composer.py	320	71	78%	335–336, 339–340, 343–344, 347–348, 355–356, 359–360, 389, 391, 393, 396, 399, 404, 407, 411, 414, 456–489, 494–505, 510–516, 521–529, 549–562, 566, 590, 593–610, 618, 643, 659–660, 662–663, 665–666, 668–669, 671–672, 678–682
TOTAL	2434	295	88%