Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: addressing internal feedback (3) #134

Merged
merged 7 commits into from
Feb 5, 2025
Merged

Conversation

aorumbayev
Copy link
Contributor

@aorumbayev aorumbayev commented Feb 3, 2025

Proposed Changes

  • Resolving edge case when auto fee handling would fail on readonly app calls (reported by Cosimo)
  • Resolving typos in algo sdk client network abstractions to respect the port property
  • Fixing auto generated docs urls (note still not updating html folder just yet, to be done prior to prod release)
  • Further aligning static get_{}_client methods in ClientManager abstraction to require config (instead of keeping it optional).

@aorumbayev aorumbayev force-pushed the fix/feedback-batch-3 branch from 51500a4 to 2da92db Compare February 3, 2025 22:40
Copy link

github-actions bot commented Feb 3, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/algokit_utils
   _debugging.py1411887%21, 40–42, 45, 54, 62, 81, 87, 96, 110–114, 133, 141–143
   account.py330%1–12
   algorand.py981585%62–63, 74–75, 95–96, 108–110, 119–120, 214, 234, 247, 263
   application_client.py330%1–11
   application_specification.py770%1–39
   config.py891880%26–28, 41, 53, 84–85, 100, 105, 110, 118–123, 153, 155, 157
   deploy.py330%1–10
   logic_error.py330%1–10
src/algokit_utils/_legacy_v2
   _ensure_funded.py71199%100
   _transfer.py70396%14, 75–76
   account.py931386%15–18, 70–74, 109, 126, 156, 159, 203
   application_client.py5367786%56–57, 175, 180, 209, 321, 326–327, 329, 331, 800, 815, 833–836, 930, 970, 982, 995, 1037, 1097–1103, 1107–1112, 1114, 1150, 1157, 1270, 1306, 1320, 1358–1360, 1362, 1372–1429, 1440–1445, 1465–1468
   asset.py80495%24–27
   common.py13192%13
   deploy.py4072295%32–35, 170, 174–175, 193, 249, 339–340, 361, 395, 406–414, 429, 437, 593–594, 618
   network_clients.py73593%77–78, 101–102, 135
src/algokit_utils/accounts
   account_manager.py2133385%162, 181–182, 206–211, 229–230, 247, 264–269, 316–318, 347, 386, 406–410, 423, 482, 503, 660, 766, 845, 850, 869–870, 893
   kmd_account_manager.py741086%49–55, 96, 152, 159
src/algokit_utils/applications
   abi.py1307145%14, 74, 110, 116, 118, 120, 124–125, 140–159, 175, 178–184, 200–213, 226–238, 253–264
   app_client.py70221470%66–74, 133, 141, 335–338, 341, 344, 347, 350, 362–365, 368, 371, 374, 377, 389, 398, 407, 410–477, 490–548, 572–574, 591–594, 602–605, 613–616, 624–627, 635–638, 649–652, 665, 761–764, 798, 810, 822, 834, 846, 861, 876, 886, 896, 906, 916, 926, 963–976, 992, 1009, 1026, 1043, 1064, 1085, 1175, 1343, 1390–1391, 1422, 1424, 1430, 1475–1483, 1516–1519, 1522–1525, 1546, 1594, 1657–1659, 1672–1679, 1720, 1737, 1739, 1742, 1746, 1873, 1884–1885, 1908, 1918–1920, 1923–1945, 1955, 1964–1979, 1984–1989
   app_deployer.py2094081%97, 195, 202, 212–217, 220–224, 262–276, 291–292, 481–494, 504, 509, 515, 521–523, 530, 544, 555–596
   app_factory.py2662790%351, 361, 364, 508, 516, 528, 677, 691–696, 702–703, 721, 746, 757–758, 794, 802–816
   app_manager.py2181693%226, 285–286, 318–323, 349, 367–368, 398, 419–422, 445, 454
src/algokit_utils/applications/app_spec
   arc32.py95892%198–207
   arc56.py4703692%72–74, 183, 318, 336–337, 415, 437–439, 495, 504, 506, 574, 769, 779, 783, 943, 945, 978–989, 1002, 1004–1005, 1021
src/algokit_utils/assets
   asset_manager.py1061289%266–267, 276, 282–306, 316
src/algokit_utils/clients
   client_manager.py1735469%24–26, 74–81, 95, 127–129, 185, 196–199, 224, 263, 298–303, 338–340, 373, 390, 412, 446–449, 482–485, 519–522, 552–555, 573–598, 628, 637, 645
   dispenser_api_client.py841286%129–130, 134–137, 172–174, 193–195
src/algokit_utils/errors
   logic_error.py561180%14, 105–121
src/algokit_utils/models
   account.py881484%31, 33, 79–80, 127, 135, 159–166, 180–181, 189, 197
   amount.py1061784%35, 42, 88, 98, 104, 112, 117–119, 126, 131–133, 140, 147, 160, 166
   application.py42198%8
   state.py36586%51, 55–58
   transaction.py51394%66, 86, 91
src/algokit_utils/protocols
   account.py11282%17, 22
   typed_clients.py24483%12–24
src/algokit_utils/transactions
   transaction_composer.py95312887%34–41, 621, 624, 629, 633–644, 676, 717, 784, 791, 813, 846, 909–972, 1001, 1019–1021, 1027–1042, 1047, 1055, 1057, 1059, 1075, 1081, 1116–1123, 1126–1133, 1144, 1238, 1287, 1535–1536, 1575–1576, 1617, 1828, 1831, 1850, 1855, 1879–1881, 1918–1954, 1961–1968, 2109, 2112, 2237, 2239–2240, 2290–2291
   transaction_creator.py75791%116, 121, 126, 131, 136, 141, 156
   transaction_sender.py1481093%88, 243, 286–287, 431–436, 441–442, 487
TOTAL624893185% 

Tests Skipped Failures Errors Time
400 0 💤 0 ❌ 0 🔥 5m 27s ⏱️

src/algokit_utils/models/network.py Outdated Show resolved Hide resolved
src/algokit_utils/clients/client_manager.py Show resolved Hide resolved
src/algokit_utils/transactions/transaction_composer.py Outdated Show resolved Hide resolved
src/algokit_utils/transactions/transaction_composer.py Outdated Show resolved Hide resolved
src/algokit_utils/transactions/transaction_composer.py Outdated Show resolved Hide resolved
tests/transactions/test_resource_packing.py Outdated Show resolved Hide resolved
tests/transactions/test_resource_packing.py Outdated Show resolved Hide resolved
@aorumbayev aorumbayev force-pushed the fix/feedback-batch-3 branch from c82074b to ea0ed46 Compare February 5, 2025 18:53
@aorumbayev aorumbayev force-pushed the fix/feedback-batch-3 branch from ea0ed46 to 2d4eeac Compare February 5, 2025 18:54
@aorumbayev aorumbayev merged commit b8071a8 into main Feb 5, 2025
4 checks passed
@aorumbayev aorumbayev deleted the fix/feedback-batch-3 branch February 5, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants