feat: logic error logging #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-p
commented
Dec 13, 2024
| await externalClient.send.call({ method: 'error' }) | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| } catch (e: any) { | ||
| expect(e.stack).toMatch(`err <--- Error`) |
There was a problem hiding this comment.
Just noting that this was working before this PR. Just wanted to make the test more explicit to catch any future regressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Config.logger.errorThis is useful in test environments because some frameworks (jest, vitest) cut off errors. This means the framework will only show the unparsed logic error with the PC and opcodes. This PR adds explicit logging with the stack from the LogicError to ensure the developer gets feedback on where the error occurs