feat: add heartbeat data to indexer types #372
Conversation
| * | ||
| * *Pattern:* `"^(?:[A-Za-z0-9+/]{4})*(?:[A-Za-z0-9+/]{2}==\|[A-Za-z0-9+/]{3}=)?$"` | ||
| */ | ||
| 'hb-pk'?: string |
There was a problem hiding this comment.
This optionality is a little strange, however it mirrors the indexer api docs. https://developer.algorand.org/docs/rest-apis/indexer/#transactionheartbeat
It also matches the algosdk@3 type https://github.com/algorand/js-algorand-sdk/blob/develop/src/client/v2/indexer/models/types.ts#L7497 and https://github.com/algorand/js-algorand-sdk/blob/develop/src/client/v2/indexer/models/types.ts#L4354
There was a problem hiding this comment.
I agree. All the props in hb-proof are optional, but hb-proof is not. Seems weird but good that it matches SDK and indexer API.
neilcampbell
force-pushed
the
hb-types
branch
from
afb4b90 to
ac29f38
Compare
| * | ||
| * *Pattern:* `"^(?:[A-Za-z0-9+/]{4})*(?:[A-Za-z0-9+/]{2}==\|[A-Za-z0-9+/]{3}=)?$"` | ||
| */ | ||
| 'hb-pk'?: string |
There was a problem hiding this comment.
I agree. All the props in hb-proof are optional, but hb-proof is not. Seems weird but good that it matches SDK and indexer API.
Adding heartbeat transaction data to the indexer types.
This change is only required in v7 (hence
main-v7target), as v8 leverages the indexer types introduced in algosdk@3.