fix(ui): remove incorrect pool max stake calculations #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove logic that incorrectly divided validator's hard max stake limit evenly between pools. Each pool now correctly shows its max capacity based on either the validator's configured limit or the `maxAlgoPerPool` protocol constraint, while the validator's total stake remains capped by `maxAlgoPerValidator` protocol constraint. Extract progress bar display logic into reusable `StakeProgressBar` component.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes how pool stake maximums are calculated and displayed. Previously, the validator's total stake limit was incorrectly divided evenly between all pools. Now each pool correctly shows its individual maximum based on either the validator's configured limit or the
maxAlgoPerPoolprotocol constraint.Details
maxAlgoPerValidatorevenly between poolsmaxAlgoPerValidatorStakeProgressBarcomponent