Changes for block incentives and v11 opcodes #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannotti
force-pushed
the
algorand-v4
branch
3 times, most recently
from
51a338d to
1781094
Compare
jannotti
force-pushed
the
algorand-v4
branch
from
1781094 to
4039875
Compare
nullun
reviewed
Dec 19, 2024
giuliop
approved these changes
Dec 19, 2024
tasosbit
approved these changes
Dec 19, 2024
SilentRhetoric
approved these changes
Dec 19, 2024
cusma
reviewed
Dec 20, 2024
There was a problem hiding this comment.
LGTM. The only comments are about: missing FeeSink behavior in case of insufficient funds for the payout, a better specification of the units used in the descriptions of some fields/opcodes (as-in: microlgos should be used instead of algos), and some minor typos.
| @@ -470,6 +470,11 @@ Fields | |||
| | 15 | AssetCreateMinBalance | uint64 | v10 | The additional minimum balance required to create (and opt-in to) an asset. | | |||
| | 16 | AssetOptInMinBalance | uint64 | v10 | The additional minimum balance required to opt-in to an asset. | | |||
| | 17 | GenesisHash | [32]byte | v10 | The Genesis Hash for the network. | | |||
| | 18 | PayoutsEnabled | bool | v11 | Whether block proposal payouts are enabled. | | |||
| | 19 | PayoutsGoOnlineFee | uint64 | v11 | The fee required in a keyreg transaction to make an account incentive eligible. | | |||
There was a problem hiding this comment.
Should we specify this number is in microalgos?
Comment on lines
+476
to
+477
| | 21 | PayoutsMinBalance | uint64 | v11 | The minimum algo balance an account must have in the agreement round to receive block payouts in the proposal round. | | ||
| | 22 | PayoutsMaxBalance | uint64 | v11 | The maximum algo balance an account can have in the agreement round to receive block payouts in the proposal round. | |
There was a problem hiding this comment.
Same as before, I think it would be better to point out the min/max are expressed in microalgos (unless I'm missing something).
cusma
reviewed
Dec 20, 2024
cusma
reviewed
Dec 20, 2024
Comment on lines
+596
to
+597
| Participation updates contains a two list of addressess of accounts | ||
| for which changes are made to their particpation status. |
There was a problem hiding this comment.
Typos: addressess (LOC 596) and particpation (LOC 597)
cusma
reviewed
Dec 20, 2024
|
|
||
| The second contains accounts that have been deemed to be | ||
| _suspended_. An account is said to be suspended according to the rules | ||
| specified above for _suspended particpation accounts_ list. Once |
There was a problem hiding this comment.
Typo: particpation (LOC 607)
cusma
reviewed
Dec 20, 2024
cusma
reviewed
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds explanations for block incentive payouts, heartbeat transactions, logicsig pooling and AVM v11 opcodes.