Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve a issue that JNA could not map bool correctly #2376

Merged
merged 5 commits into from
Jan 10, 2023

Conversation

siyuan0322
Copy link
Collaborator

@siyuan0322 siyuan0322 commented Jan 9, 2023

ref: https://stackoverflow.com/questions/55225896/jna-maps-java-boolean-to-1-integer

This is a preview version that shows the bug of #1814 roots from the mapping of Boolean in Java to C. Probably this PR within rust version 1.61 trigger that, though I'm not sure.
@shirly121 will implement some custom mapping to fix that in a more elegant manner.

Coauthored by @BingqingLyu

Fix #1778

@siyuan0322 siyuan0322 marked this pull request as draft January 9, 2023 10:08
@siyuan0322 siyuan0322 requested a review from shirly121 January 9, 2023 11:32
@siyuan0322 siyuan0322 marked this pull request as ready for review January 9, 2023 12:04
@codecov-commenter
Copy link

Codecov Report

Merging #2376 (9b8ca82) into main (ab7d333) will decrease coverage by 33.07%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2376       +/-   ##
===========================================
- Coverage   73.08%   40.00%   -33.08%     
===========================================
  Files          88       88               
  Lines        9711     9711               
===========================================
- Hits         7097     3885     -3212     
- Misses       2614     5826     +3212     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_cython_ast.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_serailaize.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/analytical/udf/patch.py 3.47% <0.00%> (-96.53%) ⬇️
python/graphscope/tests/unittest/test_lazy.py 0.00% <0.00%> (-96.22%) ⬇️
...thon/graphscope/tests/unittest/test_scalability.py 0.00% <0.00%> (-96.16%) ⬇️
python/graphscope/tests/unittest/test_app.py 0.00% <0.00%> (-96.11%) ⬇️
...hon/graphscope/tests/unittest/test_create_graph.py 0.00% <0.00%> (-92.73%) ⬇️
python/graphscope/tests/unittest/test_graph.py 0.00% <0.00%> (-85.47%) ⬇️
python/graphscope/tests/unittest/test_context.py 0.00% <0.00%> (-81.04%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab7d333...9b8ca82. Read the comment docs.

@siyuan0322 siyuan0322 merged commit 59367f8 into alibaba:main Jan 10, 2023
@siyuan0322 siyuan0322 deleted the zsy/rust2 branch January 10, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Rust 1.61 leads to Protobuf "buffer underflow" Error
3 participants