feat(interactive): support isNull expression evaluation in GIE #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3128 +/- ##
=======================================
Coverage 42.63% 42.63%
=======================================
Files 100 100
Lines 10817 10817
=======================================
Hits 4612 4612
Misses 6205 6205 Continue to review full report in Codecov by Sentry.
|
BingqingLyu
changed the title
BingqingLyu
changed the title
BingqingLyu
force-pushed
the
ir_eval_fix
branch
2 times, most recently
from
874c41f to
403d771
Compare
BingqingLyu
force-pushed
the
ir_eval_fix
branch
from
403d771 to
a7880b2
Compare
shirly121
approved these changes
Aug 22, 2023
longbinlai
approved these changes
Aug 22, 2023
| @@ -90,6 +90,8 @@ impl TryFrom<Token> for pb::ExprOpr { | |||
| } | |||
| Token::IdentArray(idents) => Ok((idents_to_vars(idents)?, false).into()), | |||
| Token::IdentMap(idents) => Ok((idents_to_vars(idents)?, true).into()), | |||
| Token::IsNull => Ok(pb::Logical::Isnull.into()), | |||
| Token::Null => Ok(pb::Value::from(pb::None {}).into()), | |||
There was a problem hiding this comment.
Token::Null still needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As titled.
Related issue number
Fixes #3127