Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): fix the docs of interactive engine #3131

Merged
merged 10 commits into from
Aug 22, 2023

Conversation

longbinlai
Copy link
Collaborator

Committed-by: longbinlai from Dev container

Fix issue #3100

Committed-by: longbinlai from Dev container

- Python3.7 ~ 3.11
- Python 3.9 ~ 3.11
- Java 11 (both Java 8 and 20 have compatibility issues)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better to list the environment requirement for all engines in the same place? it would be easier to keep them consistent.

e.g., you'll find that the following page is saying we only require Java 8 for GIE.

https://graphscope.io/docs/deployment/install_on_local#prerequisites

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. But shall we include an extra page for prerequisites. It 's actually required everywhere, and there are much more requirements than we've listed in https://graphscope.io/docs/deployment/install_on_local#prerequisites.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sighingnow I have already tried, java 8 would not work for gie any more. LoL

Committed-by: longbinlai from Dev container
sighingnow
sighingnow previously approved these changes Aug 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #3131 (f099b2b) into main (2ba0922) will increase coverage by 31.47%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3131       +/-   ##
===========================================
+ Coverage   42.63%   74.11%   +31.47%     
===========================================
  Files         100      100               
  Lines       10817    10817               
===========================================
+ Hits         4612     8017     +3405     
+ Misses       6205     2800     -3405     
Files Changed Coverage Δ
python/graphscope/interactive/query.py 83.51% <100.00%> (+6.84%) ⬆️
python/graphscope/tests/unittest/test_lazy.py 96.45% <100.00%> (+96.45%) ⬆️

... and 57 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18062f8...f099b2b. Read the comment docs.

Committed-by: longbinlai from Dev container
longbinlai and others added 2 commits August 22, 2023 01:47
Committed-by: longbinlai from Dev container
shirly121
shirly121 previously approved these changes Aug 22, 2023
Committed-by: longbinlai from Dev container
…into fix_gie_docs

Committed-by: longbinlai from Dev container
longbinlai and others added 3 commits August 22, 2023 16:25
Committed-by: longbinlai from Dev container
…into fix_gie_docs

Committed-by: longbinlai from Dev container
@longbinlai longbinlai merged commit 9b0ca43 into alibaba:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants