-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(interactive): fix the docs of interactive engine #3131
Conversation
Committed-by: longbinlai from Dev container
|
||
- Python3.7 ~ 3.11 | ||
- Python 3.9 ~ 3.11 | ||
- Java 11 (both Java 8 and 20 have compatibility issues) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better to list the environment requirement for all engines in the same place? it would be easier to keep them consistent.
e.g., you'll find that the following page is saying we only require Java 8 for GIE.
https://graphscope.io/docs/deployment/install_on_local#prerequisites
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense. But shall we include an extra page for prerequisites. It 's actually required everywhere, and there are much more requirements than we've listed in https://graphscope.io/docs/deployment/install_on_local#prerequisites.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sighingnow I have already tried, java 8 would not work for gie any more. LoL
Committed-by: longbinlai from Dev container
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3131 +/- ##
===========================================
+ Coverage 42.63% 74.11% +31.47%
===========================================
Files 100 100
Lines 10817 10817
===========================================
+ Hits 4612 8017 +3405
+ Misses 6205 2800 -3405
... and 57 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Committed-by: longbinlai from Dev container
Committed-by: longbinlai from Dev container
…into fix_gie_docs Committed-by: longbinlai from Dev container
Committed-by: longbinlai from Dev container
…into fix_gie_docs Committed-by: longbinlai from Dev container
Committed-by: longbinlai from Dev container
Fix issue #3100