fix(interactive): Fix the bug in the RexNode to Proto Conversion #3171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longbinlai
approved these changes
Sep 1, 2023
zhanglei1949
approved these changes
Sep 4, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3171 +/- ##
===========================================
- Coverage 73.25% 42.29% -30.96%
===========================================
Files 102 101 -1
Lines 11006 10907 -99
===========================================
- Hits 8062 4613 -3449
- Misses 2944 6294 +3350 see 62 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
For a specific expression, i.e.
a.age-(b.age-1), there is an issue when converting it to a proto structure, resulting in missing parentheses in the generated proto; it gets converted toa.age-b.age-1. This PR is meant to address the issue.Related issue number
Fixes