refactor(interactive): Support head(collect(XX)) in Cypher Queries
#3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3178 +/- ##
=======================================
Coverage 42.05% 42.05%
=======================================
Files 101 101
Lines 10985 10985
=======================================
Hits 4620 4620
Misses 6365 6365 Continue to review full report in Codecov by Sentry.
|
longbinlai
previously approved these changes
Sep 4, 2023
longbinlai
reviewed
Sep 4, 2023
| fn group_first_test() { | ||
| let function = pb::group_by::AggFunc { | ||
| vars: vec![common_pb::Variable::from("@".to_string())], | ||
| aggregate: 8, // ToList |
longbinlai
reviewed
Sep 4, 2023
|
|
||
| impl<D: Decode> Decode for First<D> { | ||
| fn read_from<R: ReadExt>(reader: &mut R) -> io::Result<Self> { | ||
| let max = <Option<D>>::read_from(reader)?; |
There was a problem hiding this comment.
let first = <Option<D>>::read_from(reader)?;
Ok(First { first })
longbinlai
reviewed
Sep 4, 2023
| @@ -205,4 +205,18 @@ public void with_11_test() { | |||
| + "], matchOpt=[INNER])", | |||
| project.explain().trim()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void with_12_test() { | |||
There was a problem hiding this comment.
Why all test cases are WithTest ?
There was a problem hiding this comment.
Why all test cases are
WithTest?
在cypher语法中aggregate相关的都是用在with/return里，语法层面表达为with/return的都加在WithTest，这里也可以根据具体算子再细分一下
longbinlai
approved these changes
Sep 5, 2023
zhanglei1949
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
as titled.
Related issue number
Fixes