fix: Flex add rt_bench and fix some bug #3268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liulx20
changed the title
| @@ -1384,4 +1395,4 @@ void CSVFragmentLoader::LoadFragment(MutablePropertyFragment& fragment) { | |||
| return basic_fragment_loader_.LoadFragment(fragment); | |||
| } | |||
|
|
|||
| } // namespace gs | |||
| } // namespace gs | |||
There was a problem hiding this comment.
Need empty line after file.
liulx20
changed the title
luoxiaojian
previously approved these changes
Oct 8, 2023
zhanglei1949
reviewed
Oct 8, 2023
flex/utils/arrow_utils.h
Outdated
| return true; | ||
| } | ||
|
|
||
| virtual const char* kind() const override { return "LDBC LongDate parser"; } |
There was a problem hiding this comment.
Remove virtual since override is declared.
luoxiaojian
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add rt_bench and fix some bug.
Related issue number