-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(interactive): Add support for loading graph with odps table as data source #3305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanglei1949
changed the title
feat(Interactive): Add support for loading graph with customized data source
feat(Interactive): Add support for loading graph with odps table as data source
Dec 4, 2023
zhanglei1949
changed the title
feat(Interactive): Add support for loading graph with odps table as data source
feat(interactive): Add support for loading graph with odps table as data source
Dec 5, 2023
luoxiaojian
approved these changes
Dec 5, 2023
liulx20
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ODPSFragmentLoader
to support loading vertex/edge from odps table:odps://project/table_name
ODPSFragmentLoader
andCSVFragmentLoader
all read raw data intoarrow::table
, we extract the common part to form anAbstractArrowFragmentLoader
, which provides the following interface.The
ODPSFragmentLoader
andCSVFragmentLoader
just inherit this abstract class and callAddVerticesRecordBatch
andAddEdgesRecordBatch
with lambda function indicate how to procedureRecordBatch
from eachinput_path
. ForCSVFragmentLoader
we procedure RecordBatches with arrow readers; ForODPSFragmentLoader
, we produce RecordBatches with ODPSReadClient.FLEX_OTHER_LOADERS
and callRegister()
function when customized FragmentLoader class is initialized.For example, builtin
CSVFragmentLoader
is registered forscheme=file
andformat=csv
.flex/third_party/odps/include
. These code will be opensourced by odps team but not yet ready, we just copy to here to make ourODPSFragmentLoader
works. After theodps-cpp-sdk
is opensourced, we will replace the dependency with a git submodule.Fix #3396