feat(interactive): Adapt to new unified schema #3725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanglei1949
force-pushed
the
refine-schema
branch
2 times, most recently
from
f10c2aa to
0b069d3
Compare
zhanglei1949
force-pushed
the
refine-schema
branch
5 times, most recently
from
88f0b5b to
a972196
Compare
zhanglei1949
force-pushed
the
refine-schema
branch
from
1fe84ad to
9d13103
Compare
|
Currently we can not return vertex/edge types in stored procedure, so codegen of simple_match_10.cypher fails. We will support it in the future @shirly121 . |
zhanglei1949
changed the title
schema to new unified definition
Support parsing the data type from the new unified type definition.
```yaml
GS_DATA_TYPE: # choose one
# optional value: DT_SIGNED_INT32, DT_UNSIGNED_INT32, DT_SIGNED_INT64
# DT_UNSIGNED_INT64, DT_BOOL, DT_FLOAT, DT_DOUBLE
primitive_type:
string: # choose one
long_text: # string with unlimited length
var_char: # string with variable length, bounded by max_length
max_length: <uint32>
temporal: # choose one
date32:
timestamp:
```
Also compatible with previous schema files.
migrate schema to new unified schema def
fix format and add default_value and nullable check
minor
fix
todo: fix-ci
[GIE Compiler] support new format of flex schema in compiler
minor fix
minor fix
minor
revert unneccessary changes
fix
remove unused ci
fix ci
fix
fix
add description
minor fix
minor fix
fix
fix codegen
minor fix
fixing ci
zhanglei1949
force-pushed
the
refine-schema
branch
from
e5f41be to
ac8dc7a
Compare
shirly121
approved these changes
Apr 26, 2024
lidongze0629
approved these changes
Apr 26, 2024
This was referenced Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating the graph schema of Interactive to the Flex
Unifiedgraph schema.Those changes are included in this PR.
versionin schema, which denotes the version of the schema definition. If not given,v0.0is used. The schema of versionv0.0is exactly the previous schema definition. Therefore, the schema of the graph used previously can continue to be used without any modifications.default_valueandnullableare not supported in interactive currently.type_idandproperty_idshall not be provided by user, mutable_csr will generate the internal id instead.