fix(interactive): Fixed bug that wasted disk space #3929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What do these changes do? The interactive service generates n cache files named neo4j-xxx in the /tmp/ directory during execution, each with a size of at least **0.5GB**. These files do not get deleted when the process ends. Here, n represents the number of times the interactive server has been started or restarted. This issue was due to the previously used termination method for the compiler process, which utilized the **terminate()** function. Since terminate() does not facilitate a normal exit, it led to the compiler's inability to clean up the cache files it created. Transitioning to sending the **SIGINT signal** ensures that the compiler exits gracefully and performs the necessary cache cleanup. Sleep for up to 10 seconds to wait for the compiler process to stop
liulx20
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The interactive service generates n cache files named neo4j-xxx in the /tmp/ directory during execution, each with a size of at least 0.5GB. These files do not get deleted when the process ends. Here, n represents the number of times the interactive server has been started or restarted.
This issue was due to the previously used termination method for the compiler process, which utilized the terminate() function. Since terminate() does not facilitate a normal exit, it led to the compiler's inability to clean up the cache files it created.
Transitioning to sending the SIGINT signal ensures that the compiler exits gracefully and performs the necessary cache cleanup. And sleep for up to 10 seconds to wait for the compiler process to stop