refactor(interactive): Refactor StopService API for Interactive SDKs #4271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committed-by: xiaolei.zl from Dev container
|
Please check the preview of the documentation changes at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4271 +/- ##
==========================================
+ Coverage 58.78% 63.74% +4.95%
==========================================
Files 12 126 +114
Lines 592 13235 +12643
==========================================
+ Hits 348 8436 +8088
- Misses 244 4799 +4555 see 114 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
| LOG(INFO) << "Stop service with graph: " << graph_id; | ||
| } | ||
| } catch (std::exception& e) { | ||
| LOG(ERROR) << "Fail to Start service: "; |
There was a problem hiding this comment.
Fail to Stop service?
lidongze0629
previously approved these changes
Sep 29, 2024
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
shirly121
approved these changes
Oct 9, 2024
shirly121
approved these changes
Oct 9, 2024
liulx20
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.
Fix #4265