fix(interactive): Add PVC support for Insight logs #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siyuan0322
previously approved these changes
Nov 1, 2024
charts/graphscope-store/values.yaml
Outdated
| ## | ||
| logPersistence: | ||
| ## Enable persistence using Persistent Volume Claims. If false, use emptyDir | ||
| enabled: true |
|
Please check the preview of the documentation changes at |
longbinlai
previously approved these changes
Nov 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4308 +/- ##
===========================================
- Coverage 61.08% 34.30% -26.78%
===========================================
Files 126 126
Lines 13241 13247 +6
===========================================
- Hits 8088 4545 -3543
- Misses 5153 8702 +3549 see 60 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
BingqingLyu
dismissed stale reviews from longbinlai and siyuan0322
via
63a3abf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This pull request introduces PVCs for the coordinator, frontend, and stores components within Insight.
For instance, we can get log PVCs as follows:
Related issue number
Fixes #4307