Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Return the correct port in coordinator's API #4312

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

zhanglei1949
Copy link
Collaborator

Maintain the port mapping info in coordinator, if deployed with docker.

Committed-by: xiaolei.zl from Dev container
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Please check the preview of the documentation changes at
https://dea53e88.graphscope-docs-preview.pages.dev

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.69%. Comparing base (25fa9e9) to head (923bcec).

Files with missing lines Patch % Lines
python/graphscope/gsctl/commands/dev.py 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4312       +/-   ##
===========================================
+ Coverage   34.30%   63.69%   +29.38%     
===========================================
  Files         126      126               
  Lines       13247    13252        +5     
===========================================
+ Hits         4545     8441     +3896     
+ Misses       8702     4811     -3891     
Files with missing lines Coverage Δ
python/graphscope/config.py 75.47% <100.00%> (+1.14%) ⬆️
python/graphscope/gsctl/commands/dev.py 0.00% <0.00%> (ø)

... and 70 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25fa9e9...923bcec. Read the comment docs.

@zhanglei1949 zhanglei1949 merged commit 2cd1144 into alibaba:main Nov 6, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants