Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): minor changes on list_service_status #4313

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

zhanglei1949
Copy link
Collaborator

  • Change localhost to 127.0.0.1
  • Move the comment message to a new filed info

Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Please check the preview of the documentation changes at
https://1eef50b7.graphscope-docs-preview.pages.dev

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.69%. Comparing base (2cd1144) to head (7d84b4e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4313   +/-   ##
=======================================
  Coverage   63.69%   63.69%           
=======================================
  Files         126      126           
  Lines       13252    13252           
=======================================
  Hits         8441     8441           
  Misses       4811     4811           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cd1144...7d84b4e. Read the comment docs.

Copy link
Collaborator

@pomelo-nwu pomelo-nwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhanglei1949 zhanglei1949 merged commit f41ad88 into alibaba:main Nov 6, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants