Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Cut off the string if it exceeds max_length. #4359

Merged
merged 18 commits into from
Jan 16, 2025

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Dec 12, 2024

Fix two bugs:

Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Please check the preview of the documentation changes at
https://01d75f93.graphscope-docs-preview.pages.dev

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.78%. Comparing base (3b0e2f7) to head (762e626).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4359   +/-   ##
=======================================
  Coverage   58.78%   58.78%           
=======================================
  Files          12       12           
  Lines         592      592           
=======================================
  Hits          348      348           
  Misses        244      244           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b0e2f7...762e626. Read the comment docs.

Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
@zhanglei1949 zhanglei1949 changed the title fix(interactive): Fix error on macos fix(interactive): Cut off the string if it exceed max_length Dec 13, 2024
@zhanglei1949 zhanglei1949 changed the title fix(interactive): Cut off the string if it exceed max_length fix(interactive): Cut off the string if it exceeds max_length. Dec 13, 2024
Committed-by: xiaolei.zl from Dev container
@zhanglei1949
Copy link
Collaborator Author

TODO: We should support VAR_CHAR on compiler first or all. @shirly121

Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: [email protected] from Dev container
Committed-by: [email protected] from Dev container
@zhanglei1949
Copy link
Collaborator Author

zhanglei1949 commented Jan 7, 2025

TODO: We should support VAR_CHAR on compiler first or all. @shirly121

Implemented via #4367

Committed-by: [email protected] from Dev container
Committed-by: [email protected] from Dev container
luoxiaojian
luoxiaojian previously approved these changes Jan 16, 2025
Committed-by: [email protected] from Dev container
@zhanglei1949 zhanglei1949 requested a review from lnfjpt January 16, 2025 11:36
@zhanglei1949 zhanglei1949 merged commit a60e912 into alibaba:main Jan 16, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants