Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(interactive): Support ScanEarlyStopRule for Query Optimization #4431

Merged
merged 14 commits into from
Jan 22, 2025
Merged

refactor(interactive): Support ScanEarlyStopRule for Query Optimization #4431

merged 14 commits into from
Jan 22, 2025

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Jan 14, 2025 •
edited
Loading

What do these changes do?

Leverage 3 rules for Scan Early Stop Optimization:

  1. ScanEarlyStopRule
image
  1. ScanExpandFusionRule
image
  1. TopKPushDownRule
image

Related issue number

Fixes #4356

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

Please check the preview of the documentation changes at
https://2d01b806.graphscope-docs-preview.pages.dev

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.73%. Comparing base (17ceda1) to head (d98c73a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4431   +/-   ##
=======================================
  Coverage   35.73%   35.73%           
=======================================
  Files         126      126           
  Lines       13261    13261           
=======================================
  Hits         4739     4739           
  Misses       8522     8522

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17ceda1...d98c73a. Read the comment docs.

@longbinlai
Copy link
Collaborator

longbinlai commented Jan 17, 2025 •
edited by shirly121
Loading

added in 971025a

@longbinlai longbinlai self-requested a review January 17, 2025 03:03
@shirly121 shirly121 changed the title fix(interactive): Support ScanEarlyStopRule for Query Optimization refactor(interactive): Support ScanEarlyStopRule for Query Optimization Jan 17, 2025
shirly121 and others added 3 commits January 17, 2025 17:43
@shirly121
refine docs
95f34ab
@zhanglei1949
Merge remote-tracking branch 'upstream/main' into ir_scan_limit
88a4e5f 
Committed-by: xiaolei.zl from Dev container
@zhanglei1949
support scan+limit fuse in interactive
0498a17 
Committed-by: xiaolei.zl from Dev container
@zhanglei1949 zhanglei1949 requested a review from liulx20 January 21, 2025 07:51
@zhanglei1949
Copy link
Collaborator

@shirly121 When running MATCH(n) return n limit 0, null is returned. Please make sure this is expected behavior or not.

zhanglei1949
zhanglei1949 previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirly121
Copy link
Collaborator Author

@shirly121 When running MATCH(n) return n limit 0, null is returned. Please make sure this is expected behavior or not.

fixed in 86fe502

@zhanglei1949
fix
7b9842b 
Committed-by: [email protected] from Dev container

Committed-by: [email protected] from Dev container
@zhanglei1949
fix
88a48b1 
Committed-by: [email protected] from Dev container
liulx20
liulx20 previously approved these changes Jan 22, 2025
View reviewed changes
zhanglei1949
zhanglei1949 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirly121 shirly121 merged commit e964b99 into alibaba:main Jan 22, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liulx20 liulx20 liulx20 approved these changes

@zhanglei1949 zhanglei1949 zhanglei1949 approved these changes

@longbinlai longbinlai Awaiting requested review from longbinlai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(interactive): Support Limit Early Stop in Scan Operator
5 participants
@shirly121 @codecov-commenter @longbinlai @zhanglei1949 @liulx20