Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

读取Excel时Exception处理方式是否合理 #1618

Closed
firekirin67 opened this issue Oct 19, 2020 · 1 comment
Closed

读取Excel时Exception处理方式是否合理 #1618

firekirin67 opened this issue Oct 19, 2020 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@firekirin67
Copy link

在读取Excel的时候 自定义AnalysisEventListener内抛出定义异常后被XlsxSaxAnalyser.parseXmlSource()内的异常处理再次封装成 ExcelAnalysisException
catch (Exception e) {
throw new ExcelAnalysisException(e);
}
这样设计是否合理?导致无法正确的捕捉异常,虽然可以通过instanceof等方式去处理
@firekirin67 firekirin67 added the help wanted Extra attention is needed label Oct 19, 2020
zhuangjiaju added a commit that referenced this issue Apr 9, 2021
@zhuangjiaju
修改异常抛出逻辑 [Issue #1618]
37b1253
@zhuangjiaju
Copy link
Collaborator

后续版本修复

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@firekirin67 @zhuangjiaju