Remove cuda cub #110
Merged
Remove cuda cub #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
AppVeyor could no longer find packages. I followed recommendations for upgrading AppVeyor and hope that I didn't break anything badly. |
simogasp
reviewed
Aug 7, 2019
|
LGTM, if someone manages to build it on a windoze system just to be sure we can merge. |
simogasp
approved these changes
Aug 8, 2019
Well, it was "fixed" by asking AppVeyor for the "Visual Studio 2017" image instead of the "Visual Studio 2015" image. Other people have used "Previous Visual Studio 2015" as image. I hope that's good enough for now? |
# Conflicts: # CMakeLists.txt
julianrendell
added a commit
to julianrendell/CCTag
that referenced
this pull request
May 21, 2020
Came across this- PR alicevision#110 . So I think this section is no longer correct. But searching the repo shows a couple of places where the flag is used in the cmake files- not sure if that needs cleanup, or I'm mistaken by the title of PR alicevision#110 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to replace #103 . That PR attempts to fix a thrust::sort linker problem for sm5X that is due to an old bug in Thrust.
This is a simpler solution: CUB is removed entirely, the Thrust linker bug is fixed in an unexpected way: instead of fixing thrust::sort, just provide a StrictWeakOrdering operator implemented in a way that guarantees that it doesn't use any memory.